Added individual testplans for Kernel suites #211
Conversation
vnarapar
force-pushed
the
script_test_definitions
branch
from
d835a6e to
6ceb696
Compare
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
Please update names and descriptions for each test. I only left a comment in one case.
The other issue is lack of parameters for scripts that take them. I took a quick look and found one example: wpss_remoteproc. There are probably more.
| metadata: | ||
| format: Lava-Test Test Definition 1.0 | ||
| name: AUSanity | ||
| description: "Baseline AU Sanity test plan" |
There was a problem hiding this comment.
Please update the name and description to correspond with what the test script does.
There was a problem hiding this comment.
Updated for all tests
| - lemans evk | ||
| - monaco evk | ||
|
|
||
| run: |
There was a problem hiding this comment.
I checked the script and it takes parameters. There are no parameters in the yaml file. This means that the script runs with defaults always. It would be better to provide the defaults as input in the yaml test-definition.
There was a problem hiding this comment.
Since this script is accepting environmental variables, added export first
There was a problem hiding this comment.
This is not what I asked for. These variables should be possible to define at the test job level. Without defining variables in test-definition and using these variables in script call this is not possible. Here is an example how it should be done:
- definition of variables: https://github.com/Linaro/test-definitions/blob/master/automated/linux/smoke/smoke.yaml#L28
- calling script with variables: https://github.com/Linaro/test-definitions/blob/master/automated/linux/smoke/smoke.yaml#L35
- using in a test job: https://lava.infra.foundries.io/scheduler/job/117857/definition#defline60
vnarapar
force-pushed
the
script_test_definitions
branch
from
6ceb696 to
b0895de
Compare
Added individual test definitions for Kernel tests to run tests individually in LAVA Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>
vnarapar
force-pushed
the
script_test_definitions
branch
from
b0895de to
3de70d5
Compare
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
This is better, but there is still quite a lot improvements required. You can use the validate.py script to check if the metadata is not violating some rules:
https://github.com/Linaro/test-definitions/blob/master/validate.py
| - lemans evk | ||
| - monaco evk | ||
|
|
||
| run: |
There was a problem hiding this comment.
This is not what I asked for. These variables should be possible to define at the test job level. Without defining variables in test-definition and using these variables in script call this is not possible. Here is an example how it should be done:
- definition of variables: https://github.com/Linaro/test-definitions/blob/master/automated/linux/smoke/smoke.yaml#L28
- calling script with variables: https://github.com/Linaro/test-definitions/blob/master/automated/linux/smoke/smoke.yaml#L35
- using in a test job: https://lava.infra.foundries.io/scheduler/job/117857/definition#defline60
| @@ -0,0 +1,21 @@ | |||
| metadata: | |||
| format: Lava-Test Test Definition 1.0 | |||
| name: BWMON test | |||
There was a problem hiding this comment.
IIRC LAVA doesn't allow spaces in this field.
| metadata: | ||
| format: Lava-Test Test Definition 1.0 | ||
| name: BWMON test | ||
| description: "Test to check if cpu votes are incremented" |
There was a problem hiding this comment.
This is step in a good direction, but it would be ideal to describe in detail how the test works. Once this is done, documentation can be generated from this field. Example here:
https://test-definitions.readthedocs.io/en/latest/automated/linux/docker/docker.html
|
@vnarapar I pushed my version to #207. There are 2 test-definitions missing: v4l2 and kselftest. v4l2 has a lot of options and I don't know which are used and importand. As for kselftest, there already is a test-definition for it here: https://github.com/Linaro/test-definitions/tree/master/automated/linux/kselftest. There is no point duplicating the work. |
|
@vnarapar Would you like to close this PR? |
3 participants
Added individual test definitions for Kernel tests to run tests individually in LAVA